fix: Breadcrumb broken links #1306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e32f315:
|
This was referenced May 18, 2022
icazevedo
approved these changes
May 18, 2022
| const categoryNames = categoryPath.split('/') | ||
| const splitted = categoryPath.split('/') | ||
| const name = splitted[splitted.length - 2] | ||
| const item = splitted.map(slugify).join('/') |
There was a problem hiding this comment.
slice the category path isn't better?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
Fix broken breadcrumb links
How it works
This PR uses VTEX Catalog's
slugifyfunction to generate breadcrumb links so we don't get 404s while navigating through the store.How to test it?
/tasty-frozen-computer-80186276/pon any of our starters.Starters Deploy Preview