fix: Spot pricing sort for lowPrice/highPrice #1350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e931035:
|
This was referenced Jun 9, 2022
eduardoformiga
approved these changes
Jun 9, 2022
tlgimenes
force-pushed
the
feat/spot-price
branch
from
aa85e37
to
e931035
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
SKUs can have multiple sellers. We have an heuristic for choosing the best seller. This is written on bestOfferFirst function.This function sorts the smallest available spotPrice first.
The issue we had is that AggregateOffers's low/hight price was returning the
sellingPriceinstead of thespotPrice, making the values inconsistent.This PR addresses this issue by making low/high price return the same properties used on
bestOfferFirstStarters Deploy Preview