Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: @faststore/graphql-utils #1394

Merged
merged 2 commits into from
Jul 4, 2022
Merged

fix: @faststore/graphql-utils #1394

merged 2 commits into from
Jul 4, 2022

Conversation

tlgimenes
Copy link
Contributor

@tlgimenes tlgimenes commented Jul 4, 2022

What's the purpose of this pull request?

After changing TypeScript target, @faststore/graphql-utils started being built with es modules. This caused the following issue on the stores:

[BABEL]: Cannot use import statement outside a module (While processing: ~/vtex-sites/gatsby.store/node_modules/@faststore/graphql-utils/babel.js)

changing it to commonjs should fix the issue

@tlgimenes tlgimenes requested a review from a team as a code owner July 4, 2022 17:04
@vercel
Copy link

vercel bot commented Jul 4, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
faststore ✅ Ready (Inspect) Visit Preview Jul 4, 2022 at 5:08PM (UTC)

@tlgimenes tlgimenes added the bug Something isn't working label Jul 4, 2022
@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 4, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4f0f0e5:

Sandbox Source
Store UI Typescript Configuration

@tlgimenes tlgimenes merged commit ea4b483 into main Jul 4, 2022
@tlgimenes tlgimenes deleted the chore/fix-graphql-utils branch July 4, 2022 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants