Docs/improvement/extending schema 04082022

[PedroAntunesCosta]

What's the purpose of this pull request?

Improving the guide on extending the FastStore API schema.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
faststore	✅ Ready (Inspect)	Visit Preview	Aug 19, 2022 at 8:38PM (UTC)

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b06d8b1:

Sandbox	Source
Store UI Typescript	Configuration

[victorhmp]

Awesome!! 🎉 🎉 🎉

[eduardoformiga]

Good Job! 👏

I think there is a final step missing, though:
pass the finalSchema to the getEnvelop method, like here. What do you think?

[PedroAntunesCosta]

Thanks for the review, @eduardoformiga!

I left that part out because of some reasons:

• The getEnvelop part is not exclusive for extending, projects need that to use the API.
• There are alternatives to envelope, which work differently.
• In the last example, I directed the user to change the name of the old schema instead of changing the final one.

However, I appreciate your point and think this guide would be better and cause less confusion if I add a section about that part of the code.

To do that, I would like to find a way to talk about that step in a generic way, even if the code example is based in the starters, which use envelope. Could I say that in this step we are creating a server? How would you put this if you were talking about what the role of envelope or apollo is?

[eduardoformiga]

Thanks for the review, @eduardoformiga!

I left that part out because of some reasons:

• The getEnvelop part is not exclusive for extending, projects need that to use the API.
• There are alternatives to envelope, which work differently.
• In the last example, I directed the user to change the name of the old schema instead of changing the final one.

However, I appreciate your point and think this guide would be better and cause less confusion if I add a section about that part of the code.

To do that, I would like to find a way to talk about that step in a generic way, even if the code example is based in the starters, which use envelope. Could I say that in this step we are creating a server? How would you put this if you were talking about what the role of envelope or apollo is?

Agree with all your points!
Not sure about creating a server because Envelop is more like a GraphQL plugin library. Maybe I'd put that in that step we are integrating with the GraphQL layer or enriching the GraphQL execution layer with new features (like extending the schema).

We can also go ahead, and add this afterward. So I'll approve this PR!

[eduardoformiga]

Awesome!