-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs/improvement/extending schema 04082022 #1436
Docs/improvement/extending schema 04082022 #1436
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit b06d8b1:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!! 🎉 🎉 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good Job! 👏
I think there is a final step missing, though:
pass the finalSchema
to the getEnvelop
method, like here. What do you think?
apps/docs/docs/how-to-guides/faststore-api/extending-the-faststore-api.md
Outdated
Show resolved
Hide resolved
…tore-api.md Co-authored-by: Eduardo Formiga <eduardo.formiga@gmail.com>
Thanks for the review, @eduardoformiga! I left that part out because of some reasons:
However, I appreciate your point and think this guide would be better and cause less confusion if I add a section about that part of the code. To do that, I would like to find a way to talk about that step in a generic way, even if the code example is based in the starters, which use envelope. Could I say that in this step we are creating a server? How would you put this if you were talking about what the role of envelope or apollo is? |
Agree with all your points! We can also go ahead, and add this afterward. So I'll approve this PR! |
::: | ||
|
||
GraphQL is a very versatile language. By using the exported `getSchema` function, you can not only extend the base schema but also redefine the whole resolvers implementation. | ||
### Integrate with the GraphQL layer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
What's the purpose of this pull request?
Improving the guide on extending the FastStore API schema.