Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use Next 13 in faststore/core #2198

Merged
merged 4 commits into from
Jan 30, 2024
Merged

Conversation

eduardoformiga
Copy link
Member

@eduardoformiga eduardoformiga commented Jan 15, 2024

This PR includes Breaking changes.

What's the purpose of this pull request?

This PR aims to enable the Next 13 versions in FastStore V2 after cicd platform supports it.

How to test it?

use starter.store's preview.

Starters Deploy Preview

@eduardoformiga eduardoformiga added the don't merge Blocked by some reason label Jan 15, 2024
Copy link

vercel bot commented Jan 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
faststore-site ⬜️ Ignored (Inspect) Visit Preview Jan 26, 2024 9:03pm

Copy link

codesandbox-ci bot commented Jan 15, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0675f88:

Sandbox Source
Store UI Typescript Configuration

@eduardoformiga eduardoformiga changed the title test next 13 fs 2 feat: use Next 13 in faststore/core Jan 17, 2024
@eduardoformiga eduardoformiga added the breaking changes This pull request will introduce breaking changes label Jan 17, 2024
@eduardoformiga eduardoformiga marked this pull request as ready for review January 17, 2024 21:29
@eduardoformiga eduardoformiga requested a review from a team as a code owner January 17, 2024 21:29
@eduardoformiga eduardoformiga requested review from icazevedo, lucasfp13 and gvc and removed request for a team January 17, 2024 21:29
@eduardoformiga eduardoformiga changed the base branch from main to 3.x January 30, 2024 14:53
@eduardoformiga eduardoformiga merged commit 1883bd4 into 3.x Jan 30, 2024
6 of 7 checks passed
@eduardoformiga eduardoformiga deleted the feat/test-next-13-fs-2 branch January 30, 2024 15:16
@eduardoformiga eduardoformiga mentioned this pull request Jan 30, 2024
eduardoformiga added a commit that referenced this pull request Jan 31, 2024
## What's the purpose of this pull request?

This PR holds the PRs that will be available in 3.x version:

- #2184 
- #2198 
- #2176

Preview PR
- vtex-sites/starter.store#360

---------

Co-authored-by: Fanny <fanny.chien@vtex.com.br>
Co-authored-by: Ícaro Azevedo <icaro.azevedo@vtex.com>
Co-authored-by: Mariana Caetano Pereira <67270558+Mariana-Caetano@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking changes This pull request will introduce breaking changes don't merge Blocked by some reason
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants