Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hooks exports. Remove unneeded deps. Update deps. #37

Merged
merged 4 commits into from
Aug 4, 2020

Conversation

kaisermann
Copy link
Contributor

@kaisermann kaisermann commented Aug 4, 2020

  • Fix @testing-library/... exports
  • Kept exported renderHook method, but also added a hooks bag of methods because the default act() doesn't work properly with hooks, so the user must use hooks.act()
  • Added our prettier and eslint configs
  • Removed unneeded dependencies
  • Removed some unused code
  • Fix typings for extended dom matchers

@kaisermann kaisermann requested review from klzns and jgfidelis August 4, 2020 15:53
@kaisermann kaisermann marked this pull request as draft August 4, 2020 15:54
@kaisermann kaisermann marked this pull request as ready for review August 4, 2020 17:06
@kaisermann kaisermann requested a review from a team August 4, 2020 17:07
@kaisermann kaisermann force-pushed the fix/typings branch 2 times, most recently from 3940641 to a49de7a Compare August 4, 2020 17:20
const { MockedProvider } = require('@apollo/react-testing')
const { IntlProvider } = require('react-intl')
const { path, find, isNil, reject } = require('ramda')
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

muahahaha

@kaisermann kaisermann requested a review from lucasecdb August 4, 2020 17:25
@kaisermann kaisermann self-assigned this Aug 4, 2020
react.js Outdated Show resolved Hide resolved
@kaisermann kaisermann requested a review from rafarubim August 4, 2020 18:00
README.md Outdated Show resolved Hide resolved
react.js Outdated Show resolved Hide resolved
@kaisermann kaisermann merged commit f2e4c4b into master Aug 4, 2020
@kaisermann kaisermann deleted the fix/typings branch August 4, 2020 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants