Misc changes in dotnet module #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
vthib
commented
Apr 11, 2024
vthib
commented
- Fixes a few bug found after testing the module on more varied dotnet files.
- Add handling of several undocumented but valid tables & flags
- Add a few tests as well
- Add a recursion limit for type building
Some tables and flags are not documented by ECMA 335, but can be used in dotnet files. They are of course used in malwares to prevent analysis, so add some handling for undocumented stuff.
Some table types are documented as having only a single table declared for a valid dotnet module. Of course, malwares will put multiple tables for this type. We used to pick the latest one, while yara picks the first one. Modify the behavior to align with YARA.
The method signature was evaluated on every preceding class instead of only on the class that owns the method.
On some files, notably malwares, those values can be invalid or unset. Align on the YARA behavior which is a bit erratic on its undefined/empty string handling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.