fix bug in global rules declared after normal rules #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a global rule was declared before a normal rule, and both declared strings, the matches of the strings of the normal rule were used to evaluate the global rule. This is fixed by splicing the variables of the global rules earlier in the variables vec, so that the whole variables vec respects the global_rules ++ rules order.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a global rule was declared before a normal rule, and both declared strings, the matches of the strings of the normal rule were used to evaluate the global rule.
This is fixed by splicing the variables of the global rules earlier in the variables vec, so that the whole variables vec respects the global_rules ++ rules order.