Make Scanner object unwind safe #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a wrapper struct for ModuleUserData rather than a type alias. This will allow modifying the impl on it, notably the Debug one which will be lost when bounds on UnwindSafe are added.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #171 +/- ##
=======================================
Coverage 98.60% 98.60%
=======================================
Files 80 80
Lines 24490 24507 +17
=======================================
+ Hits 24149 24166 +17
Misses 341 341 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add UnwindSafe and RefUnwindSafe bounds on objects stored in the Scanner. This makes the Scanner object unwind safe, and thus usable across a catch_unwind, which can be useful in some contexts.