Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify module evaluation #80

Merged
merged 3 commits into from
Oct 22, 2023
Merged

Simplify module evaluation #80

merged 3 commits into from
Oct 22, 2023

Commits on Oct 22, 2023

  1. feat: rework how module values are evaluated 

    Put all expressions in a single vec, so that it can be evaluated on its
own, before evaluating the module operations. This will allow cleaning
the code in the next commits are removing some Arc.
    @vthib
    vthib committed Oct 22, 2023
    Configuration menu
    Copy the full SHA
    50ad192 View commit details
    Browse the repository at this point in the history

  2. refacto: rework ModuleExpression object

    @vthib
    vthib committed Oct 22, 2023
    Configuration menu
    Copy the full SHA
    a2caf02 View commit details
    Browse the repository at this point in the history

  3. feat: remove Arc used around module values 

    Those were needed to fix ownership issues when evaluating module values
with operations chains. This has been fixed by moving the evaluation of
the expressions used in operations outside of the evaluation of those
operations.
    @vthib
    vthib committed Oct 22, 2023
    Configuration menu
    Copy the full SHA
    63cdd74 View commit details
    Browse the repository at this point in the history