Remove Objective-C compatibility, fix #89

vtourraine · Sep 17, 2021 · 52aac60 · 52aac60
1 parent 081cead
commit 52aac60
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 7 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,6 +5,11 @@
 - Add SwiftUI interface (supports iOS/tvOS/watchOS/macOS)
 
 
+## 2.0.2 (17 September 2021)
+
+- Update `AcknowListViewController` to remove Objective-C compatibility, fixing Xcode 13 support
+
+
 ## 2.0.1 (26 April 2021)
 
 - Update `AcknowListViewController` to make initializers available with Objective-C

diff --git a/Examples/AcknowExampleManual/AcknowExample/ObjCViewController.m b/Examples/AcknowExampleManual/AcknowExample/ObjCViewController.m
@@ -28,12 +28,14 @@
 @implementation ObjCViewController
 
 - (void)presentAcknowListViewController {
-    NSString *path = @"";
-    AcknowListViewController *viewController = [[AcknowListViewController alloc] initWithPlistPath:path style:UITableViewStylePlain];
-    viewController.headerText = @"...";
-    viewController.footerText = @"...";
+    // Objective-C compatibility has been disabled, see: https://github.com/vtourraine/AcknowList/issues/89
+    //
+    // NSString *path = @"";
+    // AcknowListViewController *viewController = [[AcknowListViewController alloc] initWithPlistPath:path style:UITableViewStylePlain];
+    // viewController.headerText = @"...";
+    // viewController.footerText = @"...";
 
-    [self presentViewController:viewController animated:YES completion:nil];
+    // [self presentViewController:viewController animated:YES completion:nil];
 }
 
 @end
diff --git a/Sources/AcknowList/AcknowListViewController.swift b/Sources/AcknowList/AcknowListViewController.swift
@@ -76,7 +76,7 @@ open class AcknowListViewController: UITableViewController {
 
      - returns: The new `AcknowListViewController` instance.
      */
-    @objc public convenience init(fileNamed fileName: String) {
+    public convenience init(fileNamed fileName: String) {
         if let path = AcknowListViewController.acknowledgementsPlistPath(name: fileName) {
             self.init(plistPath: path)
         }
@@ -94,7 +94,7 @@ open class AcknowListViewController: UITableViewController {
 
      - returns: The new `AcknowListViewController` instance.
      */
-    @objc public convenience init(plistPath: String, style: UITableView.Style = .grouped) {
+    public convenience init(plistPath: String, style: UITableView.Style = .grouped) {
         self.init(acknowledgements: [], style: style)
 
         load(from: plistPath)