-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom style #69
Custom style #69
Conversation
Hello Matt, and thanks a lot for preparing this pull request 👍 I appreciate that you want to tailor the library to your app’s needs, but I try to limit the number of options built into the library itself, while keeping the door open for client-specific customizability. For the custom title, I think it’s better to just set the Keeping the number of options to a minimum really helps with code maintainability and accessibility. I hope you understand my reasoning. |
@ApolloZhu Ah, you’re right, I was thinking of essentially calling As it happens, another pull request just got opened with the same request: #70. So I’m starting to reconsider the “table view style” parameter. @Lumus, would you like to update your branch to remove the |
All good. It hadn't even crossed my mind to set the title externally HAHA. Will update the PR shortly |
@Lumus Thank you for the follow-up changes (and for updating the unit tests, documentation, and example app too 👏👏👏). I’ve updated your branch to tighten the code a bit. The main change is that I’ve reverted the convenience initializers of What do you think? |
@vtourraine 👍 I have no issues with the changes you made. I'll admit I have a tendency towards "give the user as many options as possible" but that can come at the cost of too much complexity hehe. In this though limiting the options on the API "surface" will be beneficial. 😄 |
The purpose of this PR is to provide users with the capacity to expose the default table view style with any valid
UITableView.Style
option, and to provide a custom title for the presented view controller:UITableViewController
accepts aUITableView.Style
property in one of it's initialisers. This change allows a user to override the default.grouped
with either.plain
or.insetGrouped
(available on iOS/iPad OS 13.0 +) to match their app's UI design when instantiating a newAcknowListViewController
AcknowListViewController