-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v12 compatibility fixes #517
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wyrmisis
reviewed
Jun 12, 2024
wyrmisis
reviewed
Jun 12, 2024
wyrmisis
reviewed
Jun 12, 2024
wyrmisis
reviewed
Jun 12, 2024
anthonyronda
approved these changes
Jul 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Comment on lines
7
to
13
"minimumCoreVersion": "10", | ||
"compatibleCoreVersion": "11", | ||
"compatibleCoreVersion": "12", | ||
"compatibility": { | ||
"minimum": "10", | ||
"verified": "11", | ||
"maximum": "11" | ||
"maximum": "12" | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this will probably be changed in a later chore PR
@all-contributors please add arcos for code |
I've put up a pull request to add @arcos! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just started plugging away at this so OSE is usable in v12. I am not sure what the plan is, but hopefully this helps. Fixes dice rolls and makes the character sheets update again.