Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v12 compatibility fixes #517

Merged
merged 9 commits into from
Jul 1, 2024
Merged

v12 compatibility fixes #517

merged 9 commits into from
Jul 1, 2024

Conversation

arcos
Copy link
Contributor

@arcos arcos commented Jun 8, 2024

I just started plugging away at this so OSE is usable in v12. I am not sure what the plan is, but hopefully this helps. Fixes dice rolls and makes the character sheets update again.

src/module/settings.ts Outdated Show resolved Hide resolved
src/ose.js Outdated Show resolved Hide resolved
src/ose.js Outdated Show resolved Hide resolved
@anthonyronda anthonyronda self-requested a review July 1, 2024 15:05
Copy link
Member

@anthonyronda anthonyronda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines 7 to 13
"minimumCoreVersion": "10",
"compatibleCoreVersion": "11",
"compatibleCoreVersion": "12",
"compatibility": {
"minimum": "10",
"verified": "11",
"maximum": "11"
"maximum": "12"
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will probably be changed in a later chore PR

@anthonyronda anthonyronda merged commit f2029c4 into vttred:main Jul 1, 2024
@anthonyronda
Copy link
Member

@all-contributors please add arcos for code

Copy link
Contributor

@anthonyronda

I've put up a pull request to add @arcos! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants