Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The advice from vuejs-accessibility/accessible-emoji appears to lead to a degraded experience with assistive technologies #300

Closed
slaweet opened this issue Oct 15, 2021 · 2 comments · Fixed by #301 or #320
Closed

The advice from vuejs-accessibility/accessible-emoji appears to lead to a degraded experience with assistive technologies #300

slaweet opened this issue Oct 15, 2021 · 2 comments · Fixed by #301 or #320

Comments

@slaweet
Copy link
Contributor

slaweet commented Oct 15, 2021

The problem is analogical to jsx-eslint/eslint-plugin-jsx-a11y#627, which contains all the details.

TL;DR vuejs-accessibility/accessible-emoji rule should be deprecated and removed from recommended rule lists
@kddnewton
Copy link
Collaborator

Nice. I'll deprecate it as well.

@kddnewton kddnewton mentioned this issue Oct 15, 2021
Merged
@slaweet
Copy link
Contributor Author

slaweet commented Oct 17, 2021

Cool. Thank you for such a quick fixing.

Though I think it should also be removed from

eslint-plugin-vuejs-accessibility/src/configs/recommended.ts

Line 15 in fde0bbc

"vuejs-accessibility/accessible-emoji": "error",

@slaweet slaweet mentioned this issue Oct 25, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@slaweet @kddnewton