Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The advice from jsx-a11y/accessible-emoji appears to lead to a degraded experience with assistive technologies #627

Closed
luke-john opened this issue Aug 1, 2019 · 2 comments · Fixed by #713
Closed

The advice from jsx-a11y/accessible-emoji appears to lead to a degraded experience with assistive technologies #627

luke-john opened this issue Aug 1, 2019 · 2 comments · Fixed by #713
Assignees
@jessebeach

Comments

@luke-john
Copy link

luke-john commented Aug 1, 2019 •
edited
Loading

From some testing on os x with VoiceOver, it seems the guidance provided in the rule jsx-a11y/accessible-emoji leads to a degraded experience with the label not being announced to the user.

I've setup a codepen which demonstrates this at the following link.

https://codepen.io/anon/pen/ymoBgb

The rule seemed to have been created based on the advice in a blog post from a few years ago now, so perhaps browsers and assistive technologies have advanced since then.

https://github.com/evcohen/eslint-plugin-jsx-a11y/pull/136
@luke-john luke-john mentioned this issue May 11, 2020
Closed
@jessebeach
Copy link
Collaborator

@luke-john great suggestion. You're totally right. Emojis have evolved since this rule was created and it no longer makes sense. I'm going to deprecate this rule in the current version and we'll remove it in the next version.

@jessebeach jessebeach mentioned this issue Jun 22, 2020
Merged
@beefancohen
Copy link
Contributor

Thank you!!!!

@ljosberinn ljosberinn mentioned this issue Jun 30, 2020
Closed
@Lily418 Lily418 mentioned this issue Jul 2, 2020
Closed
33 tasks
@k-yle k-yle mentioned this issue Oct 26, 2020
Merged
@sooinc sooinc mentioned this issue Nov 18, 2020
Merged
1 task
@UncleClapton UncleClapton mentioned this issue Nov 27, 2020
Merged
trezy added a commit to trezy/trezy.com that referenced this issue Dec 1, 2020
@trezy
remove a11yEmoji
3c85389 
It's currently breaking Markdown rendering, and my not be necessary at
all (ref: jsx-eslint/eslint-plugin-jsx-a11y#627)
@hallee hallee mentioned this issue Feb 8, 2021
Merged
backwardok added a commit to backwardok/eslint-plugin-jsx-a11y that referenced this issue Mar 25, 2021
@backwardok
Fully deprecate accessible-emoji rule
311eae5 
The [accessible-emoji rule got marked as deprecated](jsx-eslint#713) to address jsx-eslint#627, but was never removed from the rule set.

This removes the rule from the strict and recommended lists and also updates the readme to reflect it being deprecated.
@backwardok backwardok mentioned this issue Mar 25, 2021
Merged
backwardok added a commit to backwardok/eslint-plugin-jsx-a11y that referenced this issue Mar 25, 2021
@backwardok
Fully deprecate accessible-emoji rule
5960043 
The [accessible-emoji rule got marked as deprecated](jsx-eslint#713) to address jsx-eslint#627, but was never removed from the rule set.

This removes the rule from the strict and recommended lists and also updates the readme to reflect it being deprecated.
ljharb pushed a commit to backwardok/eslint-plugin-jsx-a11y that referenced this issue Apr 6, 2021
@backwardok @ljharb
Fully deprecate accessible-emoji rule
ecec8e4 
The [accessible-emoji rule got marked as deprecated](jsx-eslint#713) to address jsx-eslint#627, but was never removed from the rule set.

This removes the rule from the strict and recommended lists and also updates the readme to reflect it being deprecated.
tbergquist-godaddy added a commit to adeira/universe that referenced this issue Sep 7, 2021
@tbergquist-godaddy
eslint-config: set jsx-a11y/accessible-emoji to off
3cbeda3 
From some testing on os x with VoiceOver, it seems the guidance
provided in the rule jsx-a11y/accessible-emoji leads to a degraded
experience with the label not being announced to the user.

See [issue here](jsx-eslint/eslint-plugin-jsx-a11y#627)
@tbergquist-godaddy tbergquist-godaddy mentioned this issue Sep 7, 2021
Merged
tbergquist-godaddy added a commit to adeira/universe that referenced this issue Sep 7, 2021
@tbergquist-godaddy
eslint-config: set jsx-a11y/accessible-emoji to off
62caa5f 
From some testing on os x with VoiceOver, it seems the guidance
provided in the rule jsx-a11y/accessible-emoji leads to a degraded
experience with the label not being announced to the user.

See [issue here](jsx-eslint/eslint-plugin-jsx-a11y#627)
adeira-github-bot pushed a commit to adeira/eslint-config-adeira that referenced this issue Sep 7, 2021
@tbergquist-godaddy @adeira-github-bot
eslint-config: set jsx-a11y/accessible-emoji to off
6a383f1 
From some testing on os x with VoiceOver, it seems the guidance
provided in the rule jsx-a11y/accessible-emoji leads to a degraded
experience with the label not being announced to the user.

See [issue here](jsx-eslint/eslint-plugin-jsx-a11y#627)

adeira-source-id: 62caa5f8212b2e108dbe5d57a44e0ad4aaae55f1
@slaweet slaweet mentioned this issue Oct 15, 2021
Closed
ditsuke added a commit to ditsuke/prep-project-jan-2022 that referenced this issue Jan 22, 2022
@ditsuke
Disable the jsx-a11y's accessible emoji rule
f27a859 
This rule has been deprecated.

Ref: jsx-eslint/eslint-plugin-jsx-a11y#627
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jessebeach jessebeach

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Deprecate the accessible-emoji rule jsx-eslint/eslint-plugin-jsx-a11y
3 participants
@jessebeach @luke-john @beefancohen