Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: disable jsx-a11y/accessible-emoji rule #1167

Merged
merged 1 commit into from
Nov 18, 2020
Merged

style: disable jsx-a11y/accessible-emoji rule #1167

merged 1 commit into from
Nov 18, 2020

Conversation

sooinc
Copy link
Contributor

@sooinc sooinc commented Nov 18, 2020

Overview

Disable deprecated "jsx-a11y/accessible-emoji" lint rule.

For more context: jsx-eslint/eslint-plugin-jsx-a11y#627

PR Checklist

  • Related to JIRA ticket: EGG-476

Description

@sooinc sooinc marked this pull request as ready for review November 18, 2020 20:46
@sooinc sooinc requested a review from a team as a code owner November 18, 2020 20:46
JoshuaKGoldberg
JoshuaKGoldberg approved these changes Nov 18, 2020
View reviewed changes
Copy link
Collaborator

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@sooinc sooinc merged commit 84d9add into main Nov 18, 2020
@sooinc sooinc deleted the sc-disable-emoji-lint-rule branch November 18, 2020 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sooinc @JoshuaKGoldberg