Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eslint-config: set jsx-a11y/accessible-emoji to off #3081

Merged
merged 1 commit into from
Sep 7, 2021

Conversation

tbergquist-godaddy
Copy link
Contributor

From some testing on os x with VoiceOver, it seems the guidance
provided in the rule jsx-a11y/accessible-emoji leads to a degraded
experience with the label not being announced to the user.

See issue here

From some testing on os x with VoiceOver, it seems the guidance
provided in the rule jsx-a11y/accessible-emoji leads to a degraded
experience with the label not being announced to the user.

See [issue here](jsx-eslint/eslint-plugin-jsx-a11y#627)
@tbergquist-godaddy tbergquist-godaddy merged commit 62caa5f into master Sep 7, 2021
@tbergquist-godaddy tbergquist-godaddy deleted the remove-accessible-emoji-rule branch September 7, 2021 11:12
@mrtnzlml
Copy link
Member

mrtnzlml commented Sep 7, 2021

Nice! Thank you.

mrtnzlml added a commit that referenced this pull request Sep 7, 2021

Unverified

This user has not yet uploaded their public signing key.
Followup after: #3081

Seems like the `Emoji` wrapper is not necessary and, in fact, it's worse
than just leaving the emoji alone.
mrtnzlml added a commit that referenced this pull request Sep 7, 2021

Unverified

This user has not yet uploaded their public signing key.
Followup after: #3081

Seems like the `Emoji` wrapper is not necessary and, in fact, it's worse
than just leaving the emoji alone.
mrtnzlml added a commit that referenced this pull request Sep 7, 2021

Unverified

This user has not yet uploaded their public signing key.
Followup after: #3081
mrtnzlml added a commit that referenced this pull request Sep 7, 2021

Unverified

This user has not yet uploaded their public signing key.
Followup after: #3081
kodiakhq bot pushed a commit that referenced this pull request Sep 7, 2021

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Followup after: #3081

Seems like the `Emoji` wrapper is not necessary and, in fact, it's worse
than just leaving the emoji alone.
adeira-github-bot pushed a commit to mrtnzlml-archive/kochka.com.mx that referenced this pull request Sep 7, 2021

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Followup after: adeira/universe#3081

Seems like the `Emoji` wrapper is not necessary and, in fact, it's worse
than just leaving the emoji alone.

adeira-source-id: 502e260a957fec61bc05d822e7d6e6ccfafc7394
adeira-github-bot pushed a commit to adeira/sx-design that referenced this pull request Sep 7, 2021

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Followup after: adeira/universe#3081

Seems like the `Emoji` wrapper is not necessary and, in fact, it's worse
than just leaving the emoji alone.

adeira-source-id: 502e260a957fec61bc05d822e7d6e6ccfafc7394
kodiakhq bot pushed a commit that referenced this pull request Sep 7, 2021

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Followup after: #3081
adeira-github-bot pushed a commit to adeira/eslint-config-adeira that referenced this pull request Sep 7, 2021

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Followup after: adeira/universe#3081

adeira-source-id: a1f2d98c12d92cb2c19f621efb90ed1904d531bc
adeira-github-bot pushed a commit to adeira/abacus-backoffice that referenced this pull request Jan 29, 2022

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Followup after: adeira/universe#3081

Seems like the `Emoji` wrapper is not necessary and, in fact, it's worse
than just leaving the emoji alone.

adeira-source-id: 502e260a957fec61bc05d822e7d6e6ccfafc7394
adeira-github-bot pushed a commit to adeira/abacus-kochka that referenced this pull request Jan 29, 2022

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Followup after: adeira/universe#3081

Seems like the `Emoji` wrapper is not necessary and, in fact, it's worse
than just leaving the emoji alone.

adeira-source-id: 502e260a957fec61bc05d822e7d6e6ccfafc7394
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants