-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
eslint-config: set jsx-a11y/accessible-emoji to off #3081
Merged
Merged
+4
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From some testing on os x with VoiceOver, it seems the guidance provided in the rule jsx-a11y/accessible-emoji leads to a degraded experience with the label not being announced to the user. See [issue here](jsx-eslint/eslint-plugin-jsx-a11y#627)
michalsanger
approved these changes
Sep 7, 2021
Nice! Thank you. |
mrtnzlml
added a commit
that referenced
this pull request
Sep 7, 2021
Followup after: #3081 Seems like the `Emoji` wrapper is not necessary and, in fact, it's worse than just leaving the emoji alone.
mrtnzlml
added a commit
that referenced
this pull request
Sep 7, 2021
Followup after: #3081 Seems like the `Emoji` wrapper is not necessary and, in fact, it's worse than just leaving the emoji alone.
kodiakhq bot
pushed a commit
that referenced
this pull request
Sep 7, 2021
Followup after: #3081 Seems like the `Emoji` wrapper is not necessary and, in fact, it's worse than just leaving the emoji alone.
adeira-github-bot
pushed a commit
to mrtnzlml-archive/kochka.com.mx
that referenced
this pull request
Sep 7, 2021
Followup after: adeira/universe#3081 Seems like the `Emoji` wrapper is not necessary and, in fact, it's worse than just leaving the emoji alone. adeira-source-id: 502e260a957fec61bc05d822e7d6e6ccfafc7394
adeira-github-bot
pushed a commit
to adeira/sx-design
that referenced
this pull request
Sep 7, 2021
Followup after: adeira/universe#3081 Seems like the `Emoji` wrapper is not necessary and, in fact, it's worse than just leaving the emoji alone. adeira-source-id: 502e260a957fec61bc05d822e7d6e6ccfafc7394
adeira-github-bot
pushed a commit
to adeira/eslint-config-adeira
that referenced
this pull request
Sep 7, 2021
Followup after: adeira/universe#3081 adeira-source-id: a1f2d98c12d92cb2c19f621efb90ed1904d531bc
adeira-github-bot
pushed a commit
to adeira/abacus-backoffice
that referenced
this pull request
Jan 29, 2022
Followup after: adeira/universe#3081 Seems like the `Emoji` wrapper is not necessary and, in fact, it's worse than just leaving the emoji alone. adeira-source-id: 502e260a957fec61bc05d822e7d6e6ccfafc7394
adeira-github-bot
pushed a commit
to adeira/abacus-kochka
that referenced
this pull request
Jan 29, 2022
Followup after: adeira/universe#3081 Seems like the `Emoji` wrapper is not necessary and, in fact, it's worse than just leaving the emoji alone. adeira-source-id: 502e260a957fec61bc05d822e7d6e6ccfafc7394
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From some testing on os x with VoiceOver, it seems the guidance
provided in the rule jsx-a11y/accessible-emoji leads to a degraded
experience with the label not being announced to the user.
See issue here