-
-
Notifications
You must be signed in to change notification settings - Fork 637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fully deprecate accessible-emoji rule #782
Fully deprecate accessible-emoji rule #782
Conversation
Codecov Report
@@ Coverage Diff @@
## master #782 +/- ##
=======================================
Coverage 99.24% 99.24%
=======================================
Files 98 98
Lines 1452 1452
Branches 477 477
=======================================
Hits 1441 1441
Misses 11 11
Continue to review full report at Codecov.
|
311eae5
to
5960043
Compare
@ljharb is there a way to retry a test or do I have to rebase and push again to trigger the tests to rerun? |
@backwardok i think only a maintainer can retry one; otherwise the typical way is to close and reopen the PR. In this case, the task is failing because when rebased, there's merge conflicts. Feel free to ignore this tho; we can rebase it for you when it's ready to land. |
This comment has been minimized.
This comment has been minimized.
The [accessible-emoji rule got marked as deprecated](jsx-eslint#713) to address jsx-eslint#627, but was never removed from the rule set. This removes the rule from the strict and recommended lists and also updates the readme to reflect it being deprecated.
4b57a07
to
ecec8e4
Compare
Thanks @ljharb ! |
The accessible-emoji rule got marked as deprecated to address #627, but was never removed from the rule set.
This removes the rule from the strict and recommended lists and also updates the readme to reflect it being deprecated.