Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ref #563 - return unique validation errors #573

Merged

Conversation

zoul0813
Copy link
Member

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    feature/bug fix?
  • What is the current behavior? (You can also link to an open issue here)
    Every validator returns the "this field is required!" message when using multiple validators on required fields
  • What is the new behavior (if this is a feature change)?
    The errors array is run through Lodash's uniq() function to remove duplicate messages
  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    It should not, but if anyone has come up with ways of dealing with duplicate validation errors this may cause problems... ?

…ltiple validators from returning "this field is required", etc)
@zoul0813 zoul0813 merged commit fa934e8 into vue-generators:master Dec 22, 2018
@zoul0813 zoul0813 deleted the feature/563-unique-validation-errors branch December 22, 2018 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

when use multiple validations show multiple errors
2 participants