Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

新增filters和sorter状态,用来保留refresh时丢失已选筛选排序bug #1257

Merged
merged 1 commit into from
Nov 25, 2021

Conversation

xiangzp
Copy link
Contributor

@xiangzp xiangzp commented Oct 15, 2021

由于refresh里调用loadData未穿参数,会导致调用时已选的排序等数据在请求查询接口时丢失

First of all, thank you for your contribution! 😄

Pull request will be merged after one of collaborators approve.
Please makes sure that these form are filled before submitting your pull request, thank you!

这个变动的性质是

  • 日常 bug 修复

需求背景

  1. 描述相关需求的来源。
    使用过程中发现
  2. 要解决的问题。
    refresh时请求参数丢失
  3. 相关的 issue 讨论链接。

实现方案和 API(非新功能可选)

  1. 基本的解决思路和其他可选方案。
  2. 列出最终的 API 实现和用法。
  3. 涉及UI/交互变动需要有截图或 GIF。

对用户的影响和可能的风险(非新功能可选)

  1. 这个改动对用户端是否有影响?影响的方面有哪些?
    可能有影响
  2. 是否有可能隐含的 break change 和其他风险?

Changelog 描述(非新功能可选)

  1. 英文描述
  2. 中文描述(可选)

请求合并前的自查清单

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • Changelog 已提供或无须提供

后续计划(非新功能可选)

如果这个提交后面还有相关的其他提交和跟进信息,可以写在这里。

由于refresh里调用loadData未穿参数,会导致调用时已选的排序等数据在请求查询接口时丢失
@sendya sendya self-requested a review October 18, 2021 06:35
@sendya sendya merged commit 660a41f into vueComponent:master Nov 25, 2021
@sendya
Copy link
Member

sendya commented Nov 25, 2021

感谢 PR ,这么久才处理

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants