Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: button support link type #1077

Merged
merged 1 commit into from
Aug 12, 2019
Merged

feat: button support link type #1077

merged 1 commit into from
Aug 12, 2019

Conversation

sendya
Copy link
Member

@sendya sendya commented Aug 11, 2019

This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

What's the background?

Add one more type & style

API Realization (Optional if not new feature)

  1. button add type link

Changelog description (Optional if not new feature)

  1. English description
    button support link type
  2. Chinese description (optional)
    按钮 支持 link 链接按钮类型

Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Additional Plan? (Optional if not new feature)

If this PR related with other PR or following info. You can type here.

@netlify
Copy link

netlify bot commented Aug 11, 2019

Deploy preview for ant-desing-vue processing.

Building with commit ec10635

https://app.netlify.com/sites/ant-desing-vue/deploys/5d50330569f6c7000865296a

@codecov
Copy link

codecov bot commented Aug 11, 2019

Codecov Report

Merging #1077 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1077      +/-   ##
==========================================
+ Coverage   87.05%   87.08%   +0.02%     
==========================================
  Files         145      145              
  Lines        4837     4839       +2     
  Branches     1449     1450       +1     
==========================================
+ Hits         4211     4214       +3     
  Misses        558      558              
+ Partials       68       67       -1
Impacted Files Coverage Δ
components/button/buttonTypes.js 100% <ø> (ø) ⬆️
components/button/button.jsx 88.67% <100%> (+2.4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d1a385...ec10635. Read the comment docs.

@tangjinzhou tangjinzhou merged commit ad81186 into vueComponent:master Aug 12, 2019
@youcanping
Copy link

我升级到最新"ant-design-vue": "^1.4.0-beta.0",button还是不支持link,我什么我的出不来呢?

@github-actions
Copy link

github-actions bot commented Oct 1, 2020

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants