Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: memory leak of Trigger #1483

Merged
merged 1 commit into from
Dec 10, 2019
Merged

Conversation

Reson-a
Copy link
Contributor

@Reson-a Reson-a commented Nov 29, 2019

首先,感谢你的贡献! 😄

新特性请提交至 feature 分支,其余可提交至 master 分支。在一个维护者审核通过后合并。请确保填写以下 pull request 的信息,谢谢!~

[English Template / 英文模板]

这个变动的性质是

  • 新特性提交
  • 日常 bug 修复
  • 站点、文档改进
  • 组件样式改进
  • TypeScript 定义更新
  • 重构
  • 代码风格优化
  • 分支合并
  • 其他改动(是关于什么的改动?)

需求背景

Trigger闭包内存泄漏问题

#1482

实现方案和 API(非新功能可选)

不使用闭包变量,使用一个组件内部的引用,每次渲染都会重新赋值

对用户的影响和可能的风险(非新功能可选)

组件内部引用是否有其他风险?

Changelog 描述(非新功能可选)

  1. fix: memory leak of Trigger
  2. 修复: Trigger组件内存泄漏问题

请求合并前的自查清单

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

后续计划(非新功能可选)

如果这个提交后面还有相关的其他提交和跟进信息,可以写在这里。

@netlify
Copy link

netlify bot commented Nov 29, 2019

Deploy preview for ant-desing-vue processing.

Building with commit 8ad1a0c

https://app.netlify.com/sites/ant-desing-vue/deploys/5de0ccc6eb71800008d71f61

@codecov
Copy link

codecov bot commented Nov 29, 2019

Codecov Report

Merging #1483 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1483   +/-   ##
=======================================
  Coverage   87.92%   87.92%           
=======================================
  Files         156      156           
  Lines        5399     5399           
  Branches     1523     1523           
=======================================
  Hits         4747     4747           
  Misses        583      583           
  Partials       69       69

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42a75f8...8ad1a0c. Read the comment docs.

@tangjinzhou tangjinzhou merged commit d623430 into vueComponent:master Dec 10, 2019
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants