feat: update step #2379
Merged
feat: update step #2379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
63 tasks
tangjinzhou
requested changes
Jun 16, 2020
components/_util/props-util.js
Outdated
| export function isEmptyElement(c) { | ||
| return typeof c.type === 'symbol' && c.children.trim() === ''; | ||
| return typeof c.type === Comment; |
tangjinzhou
requested changes
Jun 16, 2020
components/steps/index.jsx
Outdated
| @@ -41,30 +39,27 @@ const Steps = { | |||
| const getPrefixCls = this.configProvider.getPrefixCls; | |||
| const prefixCls = getPrefixCls('steps', customizePrefixCls); | |||
| const iconPrefix = getPrefixCls('', customizeIconPrefixCls); | |||
| const progressDot = this.progressDot || this.$slots.progressDot; | |||
There was a problem hiding this comment.
getComponent(this, 'progressDot')
components/vc-steps/Step.jsx
Outdated
|
|
||
| function isString(str) { | ||
| return typeof str === 'string'; | ||
| } | ||
| function noop() {} | ||
| export default { | ||
| name: 'Step', | ||
| inheritAttrs: false, |
There was a problem hiding this comment.
如果声明了 inheritAttrs: false, class style 都需要单独处理
如果不声明就要单独声明事件
components/vc-steps/Steps.jsx
Outdated
| progressDot, | ||
| icons, | ||
| ...childProps, | ||
| ...this.$attrs, |
There was a problem hiding this comment.
这里只需要传 this.$attrs.slots 就可以了吧 多测试下 单测可以改一下了
There was a problem hiding this comment.
我先看看test-utils都改啥了，目前steps里面除了demo和mountTest好像没啥单测了
There was a problem hiding this comment.
这里我想了一下不用传this.$attrs了，里面没有需要从父组件传子组件的，progressDot已经从props传了
tangjinzhou
reviewed
Jun 22, 2020
| onItemClick(...args) { | ||
| const { onClick } = this.$props; | ||
|
|
||
| if (onClick) { |
| }; | ||
| return ( | ||
| <div {...stepsProps}> | ||
| {filteredChildren.map((child, index) => { | ||
| const childProps = getPropsData(child); | ||
| const childProps = child.props || {}; |
There was a problem hiding this comment.
还是用 getPropsData 不然有驼峰和下划线问题
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, thank you for your contribution! 😄
New feature please send pull request to feature branch, and rest to master branch. Pull request will be merged after one of collaborators approve. Please makes sure that these form are filled before submitting your pull request, thank you!
[中文版模板 / Chinese template]
This is a ...
What's the background?
API Realization (Optional if not new feature)
What's the effect? (Optional if not new feature)
Changelog description (Optional if not new feature)
Self Check before Merge
Additional Plan? (Optional if not new feature)