Feat Tag CheckableTag #2400
Merged
Feat Tag CheckableTag #2400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
63 tasks
Amour1688
reviewed
Jun 10, 2020
| class={this.getTagClassName(prefixCls)} | ||
| style={this.getTagStyle()} | ||
| > | ||
| <span v-show={visible} class={this.getTagClassName(prefixCls)} style={this.getTagStyle()}> |
There was a problem hiding this comment.
没注意这个不是根节点，那我加上 {...omit(this.$attr,['close'])} 就行了吗？要不要过滤掉不是 on 开头的 attr 呢？ @Amour1688
There was a problem hiding this comment.
这里还真不需要 单独挂载事件
没有设置 inheritAttrs: false, 的情况下，事件也会被默认挂载到 根节点上
这里的 close 事件绑定到根节点也没关系
😓
There was a problem hiding this comment.
好像是这样的，我一开始以为根节点是指的 Wave 组件上，不会往下传了。现在测了下应该是挂载到了实际的根节点上。
|
有冲突，还有尽量保持 commit 记录整洁 |
tangjinzhou
requested changes
Jun 11, 2020
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, thank you for your contribution! 😄
New feature please send pull request to feature branch, and rest to master branch. Pull request will be merged after one of collaborators approve. Please makes sure that these form are filled before submitting your pull request, thank you!
[中文版模板 / Chinese template]
This is a ...
请注意有个破坏性更改，Tag使用时需要用 v-model:visible 不能使用 v-model 控制现隐。 CheckableTag 需要使用 v-model:checked 不能使用 v-model 控制是否被选中