Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:assignment statement error #2465

Closed
wants to merge 1 commit into from
Closed

fix:assignment statement error #2465

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions components/vc-resize-observer/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
// based on rc-resize-observer 0.1.3
import ResizeObserver from 'resize-observer-polyfill';
import ResizeObserver from "resize-observer-polyfill";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lint 规范是单引号吧

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不好意思，没注意到自己编辑配置的代码格式化工具，这行代码this.fixedHeight = fixedHeight;应该是this.height = fixedHeight吧

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是 更新下代码格式？


// Still need to be compatible with React 15, we use class component here
const VueResizeObserver = {
name: 'ResizeObserver',
name: "ResizeObserver",
props: {
disabled: Boolean,
},
Expand Down Expand Up @@ -64,8 +64,8 @@ const VueResizeObserver = {
if (this.width !== fixedWidth || this.height !== fixedHeight) {
const size = { width: fixedWidth, height: fixedHeight };
this.width = fixedWidth;
this.fixedHeight = fixedHeight;
this.$emit('resize', size);
this.height = fixedHeight;
this.$emit("resize", size);
}
},

Expand Down