fix: avoid emit update:checked twice #3866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tangjinzhou
requested changes
Mar 28, 2021
| @@ -89,7 +89,6 @@ export default defineComponent({ | |||
| if ('checked' in props) { | |||
| this.$refs.input.checked = props.checked; | |||
| } | |||
| this.__emit('update:checked', eventObj); | |||
There was a problem hiding this comment.
radioGroup checkGroup 会无法触发 update:checked 这个事件 了 全局搜索下 VcCheckbox 看下 group 的逻辑
There was a problem hiding this comment.
这里没影响啊，https://github.com/vueComponent/ant-design-vue/blob/next/components/checkbox/Checkbox.tsx#L104 ，vcCheckbox emit change,然后通过context调用group的事件， group自己处理update:checked
There was a problem hiding this comment.
ok 我看错了 看成了 group也是 checked 事件了
tangjinzhou
approved these changes
Mar 31, 2021
| @@ -89,7 +89,6 @@ export default defineComponent({ | |||
| if ('checked' in props) { | |||
| this.$refs.input.checked = props.checked; | |||
| } | |||
| this.__emit('update:checked', eventObj); | |||
There was a problem hiding this comment.
ok 我看错了 看成了 group也是 checked 事件了
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, thank you for your contribution! 😄
New feature please send pull request to feature branch, and rest to master branch. Pull request will be merged after one of collaborators approve. Please makes sure that these form are filled before submitting your pull request, thank you!
[中文版模板 / Chinese template]
This is a ...
What's the background?
API Realization (Optional if not new feature)
What's the effect? (Optional if not new feature)
Changelog description (Optional if not new feature)
Self Check before Merge
Additional Plan? (Optional if not new feature)