Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Modify the warning in the conductutil file for attention #5424

Merged
merged 1 commit into from
Apr 1, 2022

Conversation

anflower
Copy link
Contributor

First of all, thank you for your contribution! 😄

New feature please send pull request to feature branch, and rest to master branch. Pull request will be merged after one of collaborators approve. Please makes sure that these form are filled before submitting your pull request, thank you!

[中文版模板 / Chinese template]

This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

What's the background?

  1. 当多选树 为懒加载的时候 此时存在多选的默认值为未展开节点 控制台会抛出错误 虽然功能不存在问题 但是这样是不友好的
  1. 目前将警告降级从error到warning 期待更好的解决方案
  2. Related issue link.

API Realization (Optional if not new feature)

  1. Basic thought of solution and other optional proposal.
  2. List final API realization and usage sample.
  3. GIF or snapshot should be provided if includes UI/interactive modification.

What's the effect? (Optional if not new feature)

  1. Does this PR affect user? Which part will be affected?
  2. What will say in changelog?
  3. Does this PR contains potential break change or other risk?

Changelog description (Optional if not new feature)

  1. English description
  2. Chinese description (optional)

Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Additional Plan? (Optional if not new feature)

If this PR related with other PR or following info. You can type here.

@tangjinzhou
Copy link
Member

@tangjinzhou tangjinzhou changed the base branch from next to main March 30, 2022 12:58
@anflower
Copy link
Contributor Author

anflower commented Mar 31, 2022

可以采纳吗 我看next和main分支 没有合入我的代码 还是我的代码有问题 这个问题存在警告是无疑的 但是警告等级error 感觉就并不友好 @tangjinzhou

@tangjinzhou tangjinzhou merged commit 0d06ce2 into vueComponent:main Apr 1, 2022
@nabil-emad
Copy link

@anflower still getting the same warning when using with react, is there any fix

@github-actions
Copy link

github-actions bot commented Jun 9, 2023

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants