-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
datePicker 添加默认渲染slot支持 #957
datePicker 添加默认渲染slot支持 #957
Conversation
Deploy preview for ant-desing-vue processing. Building with commit 2d909c0 https://app.netlify.com/sites/ant-desing-vue/deploys/5d2db0d03508d90008e9d709 |
Codecov Report
@@ Coverage Diff @@
## master #957 +/- ##
==========================================
- Coverage 87.25% 87.23% -0.03%
==========================================
Files 145 145
Lines 4832 4832
Branches 1423 1423
==========================================
- Hits 4216 4215 -1
Misses 572 572
- Partials 44 45 +1
Continue to review full report at Codecov.
|
components/date-picker/demo/text.md
Outdated
|
||
<cn> | ||
#### 自定义渲染 | ||
增加选择时间功能,当 `showTime` 为一个对象时,其属性会传递给内建的 `TimePicker`。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
介绍没更改 中英都是
@@ -409,6 +409,7 @@ export default { | |||
openChange: this.handleOpenChange, | |||
}, | |||
style: popupStyle, | |||
scopedSlots: $scopedSlots.default ? $scopedSlots : null, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
可以直接这样 scopedSlots: { default: input, ...this.$scopedSlots },
@@ -422,7 +423,7 @@ export default { | |||
onMouseenter={this.onMouseEnter} | |||
onMouseleave={this.onMouseLeave} | |||
> | |||
<VcDatePicker {...vcDatePickerProps}>{input}</VcDatePicker> | |||
<VcDatePicker {...vcDatePickerProps}>{$scopedSlots.default ? '' : input}</VcDatePicker> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
全部挂载到scopedSlots
后,可以直接 <VcDatePicker {...vcDatePickerProps} />
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
First of all, thank you for your contribution! 😄
New feature please send pull request to feature branch, and rest to master branch.
Pull request will be merged after one of collaborators approve.
Please makes sure that these form are filled before submitting your pull request, thank you!
[中文版模板 / Chinese template]
This is a ...
What's the background?
API Realization (Optional if not new feature)
What's the effect? (Optional if not new feature)
Changelog description (Optional if not new feature)
Self Check before Merge
Additional Plan? (Optional if not new feature)