Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider open unattached scriptInfo for external files #303

Merged
merged 2 commits into from
Oct 18, 2022
Merged

Conversation

znck
Copy link
Collaborator

@znck znck commented Oct 18, 2022

This prevents unnecessary inferred project creation and .vue files
referenced in .ts/.js rootFiles are included in correct project.

This prevents unnecessary inferred project creation and .vue files
referenced in .ts/.js rootFiles are included in correct project.
@codecov-commenter
Copy link

codecov-commenter commented Oct 18, 2022

Codecov Report

Merging #303 (785d383) into main (9c20060) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

❗ Current head 785d383 differs from pull request most recent head eee6e00. Consider uploading reports for the commit eee6e00 to get more accurate results

@@            Coverage Diff             @@
##             main     #303      +/-   ##
==========================================
- Coverage   35.22%   35.20%   -0.02%     
==========================================
  Files         164      164              
  Lines       20878    20883       +5     
  Branches      840      840              
==========================================
- Hits         7354     7352       -2     
- Misses      13524    13531       +7     
Impacted Files Coverage Δ
...plugin-vue/src/services/TypescriptPluginService.ts 0.00% <0.00%> (ø)
packages/shared/src/rpc/handlers.ts 97.42% <0.00%> (-0.52%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@znck znck merged commit 491fe1f into main Oct 18, 2022
@znck znck deleted the fix-resolution branch October 18, 2022 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants