Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slot name completion and type checking #304

Merged
merged 1 commit into from
Oct 19, 2022
Merged

Slot name completion and type checking #304

merged 1 commit into from
Oct 19, 2022

Conversation

znck
Copy link
Collaborator

@znck znck commented Oct 19, 2022

image

@codecov-commenter
Copy link

Codecov Report

Merging #304 (2ae68eb) into main (491fe1f) will increase coverage by 1.00%.
The diff coverage is 66.40%.

@@            Coverage Diff             @@
##             main     #304      +/-   ##
==========================================
+ Coverage   35.12%   36.13%   +1.00%     
==========================================
  Files         164      166       +2     
  Lines       20928    21295     +367     
  Branches      839      886      +47     
==========================================
+ Hits         7352     7694     +342     
- Misses      13576    13601      +25     
Impacted Files Coverage Δ
packages/compiler-tsx/src/template/generate.ts 0.00% <0.00%> (ø)
packages/compiler-tsx/src/template/runtime.ts 0.00% <0.00%> (ø)
packages/compiler-tsx/src/vue/compile.ts 0.00% <0.00%> (ø)
...ript-plugin-vue/src/features/CompletionsService.ts 0.00% <0.00%> (ø)
...ript-plugin-vue/src/features/DiagnosticsService.ts 0.00% <ø> (ø)
...pt-plugin-vue/src/services/TemplateSlotsService.ts 0.00% <0.00%> (ø)
...-plugin-vue/src/services/TemplateContextService.ts 91.71% <91.71%> (ø)
...plugin-vue/src/helpers/isOffsetInSourceLocation.ts 100.00% <0.00%> (+100.00%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@znck znck changed the title Slot name complection and type checking Slot name completion and type checking Oct 19, 2022
@znck znck merged commit 4675185 into main Oct 19, 2022
@znck znck deleted the feature-slots branch October 19, 2022 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants