Skip to content

Commit

Permalink
feat(gitignore): include common editor directories (#774)
Browse files Browse the repository at this point in the history 
* feat(gitignore): include common editor directories

add common editor files and directories to .gitignore

closes #772

* feat(gitignore): remove .vscode directory

remove .vscode directory from .gitignore
  • Loading branch information
@eddyerburgh @kazupon
eddyerburgh authored and kazupon committed Jun 28, 2017
1 parent 703c29e commit 19ea95c
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions template/.gitignore
View file
Original file line number Diff line number Diff line change
Expand Up @@ -11,3 +11,10 @@ test/unit/coverage
test/e2e/reports
selenium-debug.log
{{/e2e}}

# Editor directories and files
.idea
*.suo
*.ntvs*
*.njsproj
*.sln

4 comments on commit 19ea95c

@nueko
Copy link

@nueko nueko commented on 19ea95c Jun 30, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing .vscode
also should the directories be suffixed by /?

@sbusch
Copy link

@sbusch sbusch commented on 19ea95c Jun 30, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, directories should have a trailing slash, without these slashes regular files with these names would also match and be ignored.

.vscode folder shouldn't be ignored, see the answer of an VS Code team member on Stack Overflow.

Workspace specific files are in .vscode. For example, tasks.json for the Task Runner and launch.json for the debugger. (Source)

Recommended extensions for the current project can also be defined here.

@nueko
Copy link

@nueko nueko commented on 19ea95c Jul 1, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sbusch so the others IDE too,
eg: IDEA store Workspace specific files are in .idea/workspace.xmlalso there arecodeStyleSettings.xmlandjsLibraryMappings.xml`

here for clarify i generate an .gitignore template for Jetbrains by idea .gitignore plugin

# Covers JetBrains IDEs: IntelliJ, RubyMine, PhpStorm, AppCode, PyCharm, CLion, Android Studio and Webstorm
# Reference: https://intellij-support.jetbrains.com/hc/en-us/articles/206544839

# User-specific stuff:
.idea/**/workspace.xml
.idea/**/tasks.xml
.idea/dictionaries

# Sensitive or high-churn files:
.idea/**/dataSources/
.idea/**/dataSources.ids
.idea/**/dataSources.xml
.idea/**/dataSources.local.xml
.idea/**/sqlDataSources.xml
.idea/**/dynamic.xml
.idea/**/uiDesigner.xml

# Gradle:
.idea/**/gradle.xml
.idea/**/libraries

# Mongo Explorer plugin:
.idea/**/mongoSettings.xml

## File-based project format:
*.iws

## Plugin-specific files:

# IntelliJ
/out/

# mpeltonen/sbt-idea plugin
.idea_modules/

# JIRA plugin
atlassian-ide-plugin.xml

# Crashlytics plugin (for Android Studio and IntelliJ)
com_crashlytics_export_strings.xml
crashlytics.properties
crashlytics-build.properties
fabric.properties

@mul14
Copy link

@mul14 mul14 commented on 19ea95c Jul 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think ignoring editor's files, is not template responsibility. Developer's should put their own ignores files rules – specific for editor in $HOME/.config/git/ignore.

Reference: https://git-scm.com/docs/git-config#git-config-coreexcludesFile

Please sign in to comment.