Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load, render template version using helper #1202

Merged

Conversation

sudo-suhas
Copy link
Contributor

This adds a helper to meta.js so that the template version in template/config/index.js does not need manual maintenance and is instead loaded from package.json>version.

@LinusBorg LinusBorg merged commit 3f232bf into vuejs-templates:develop Dec 27, 2017
@sudo-suhas sudo-suhas deleted the template-version-helper branch December 28, 2017 03:57
@LinusBorg
Copy link
Contributor

LinusBorg commented Dec 31, 2017

@sudo-suhas That actually doesn't work for me, I just get this:

bildschirmfoto 2017-12-31 um 14 51 05

it correctly reads the version from pkg.json, but apperantly the helper returns nothing for me :/

Edit: ah, got it. You accidentally put the template-version outide of the helper: {} object in meta.js.

LinusBorg added a commit that referenced this pull request Dec 31, 2017
helper function was outside of the helpe object where it would belong
@sudo-suhas
Copy link
Contributor Author

My bad. I had tested it but must have inadvertently introduced the mistake while rebasing and removing conflicts. Very sorry.

LinusBorg added a commit that referenced this pull request Dec 31, 2017
* develop:
  bump template version
  fix bug with #1202
  Make CSS sourcemaps on by default
  Ensure page reloads in history mode serve index.html
  use old sourcemap option
  Add postcss-url to match postcss-import (#1115)
  Change engine>node{4 => 6} for template (#1206)
  Fix static file serving for publicPath != `/` (fix#1176) (#1180)
  Load, render template version using helper (#1202)
  fix typo in a comment (#1183)
  fix #1140
@LinusBorg
Copy link
Contributor

Don't worry, thanks for the continuing contributions :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants