Typo, whitespace and Style Guide fixes #1231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TypeScript comment typo in file /build/build.js
ESLint 'plugin:vue/recommended' detects this code style error. It violates the Style Guide rule: https://vuejs.org/v2/style-guide/#Component-name-casing-in-templates-strongly-recommended
exarus
changed the title
ESLint 'plugin:vue/recommended' detects the code style error in src/components/HelloWorld.js. It violates the Style Guide Strongly Recommended Rule: https://vuejs.org/v2/style-guide/#Multi-attribute-elements-strongly-recommended
LinusBorg
added a commit
that referenced
this pull request
Jan 13, 2018
* develop: bump template version (1.3.0) chore: remove extra comma (#1240) Improve template CI tests (close #1218) Revert "fix bad alias (fix #1239)" Typo, whitespace and Style Guide fixes (#1231) Update runner.js (#1235) remove unnecessary option. bumping eslint dependencies fix bad alias (fix #1239) remove duplicate lines in gitignore (#1214) fix historyFallback rewrite for Windows systems improved comments in eslintrc updated linting docs. respect eslint rule for order of options. switch to essential ruleset. add eslint-plugin-vue # Conflicts: # template/build/build.js
c0defre4k
pushed a commit
to neonblack-at/webpack
that referenced
this pull request
Jan 23, 2018
* vuejs-templates/master: (66 commits) Bump template version (1.3.1) change circleci node image to 6.12.3 to ensure node 6 compat. replace object rest spread with Object.assign for node6 compat. (fix vuejs-templates#1245) bump template version (1.3.0) chore: remove extra comma (vuejs-templates#1240) Improve template CI tests (close vuejs-templates#1218) Revert "fix bad alias (fix vuejs-templates#1239)" Typo, whitespace and Style Guide fixes (vuejs-templates#1231) Update runner.js (vuejs-templates#1235) remove unnecessary option. bumping eslint dependencies fix bad alias (fix vuejs-templates#1239) fix history fallback for windows. remove duplicate lines in gitignore (vuejs-templates#1214) fix historyFallback rewrite for Windows systems improved comments in eslintrc updated linting docs. respect eslint rule for order of options. switch to essential ruleset. add eslint-plugin-vue ... # Conflicts: # meta.js # template/package.json # template/src/components/HelloWorld.vue # template/src/main.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've fixed 3 small code style issues:
/build/build.js:tyescript->typescript->
src/App.vue.Appcomponent should declare itself asname: 'App'instead ofname: 'app'.I've found this error by applying ESLint 'plugin:vue/recommended'.
src/components/HelloWorld.vue.Each
<a>link was placed fully in a single line for the sake of simplicity.Style Guide suggests splitting elements with several attributes over several lines.
Old version:
Vue-styled version:I've found this error by applying ESLint 'plugin:vue/recommended'.