Added stylelint configuration. #842

gucong3000 · 2017-08-07T11:16:15Z

# Conflicts: # docs/structure.md # meta.js # template/.eslintrc.js # template/build/webpack.dev.conf.js # template/package.json # template/src/App.vue # template/src/components/Hello.vue # template/src/main.js

# Conflicts: # template/.eslintrc.js

aladdin-add · 2017-08-30T20:27:04Z

docs/linter.md

+  "indentation": "tab",
+  ```
+
+2. Pick "none" for ESLint preset when generating the project and define your own rules. See [Stylelint documentation](http://stylelint.io/user-guide/rules/) for more details.


ESLint => stylelint

aladdin-add

almost LGTM.

aladdin-add · 2017-08-30T20:33:16Z

template/package.json

@@ -85,6 +90,13 @@
    {{/e2e}}
    "semver": "^5.3.0",
    "shelljs": "^0.7.6",
+    {{#stylelint}}
+    "stylelint": "github:stylelint/stylelint",


I'm not sure there is a necessary to use github? it has no version control..I think.

I'm waiting for the next release of stylelint that including stylelint/stylelint#2799.

stylelint/stylelint#2838
It's going to be released in couple of days.

aladdin-add · 2017-08-30T20:41:36Z

meta.js

+    "stylelintConfig": {
+      "when": "stylelint",
+      "type": "list",
+      "message": "Pick an stylelint preset",


an => a. :(

gucong3000 · 2017-09-05T03:37:08Z

New bug of stylelint v8.1.0 block this PR: stylelint/stylelint#2853

…ylint

aladdin-add · 2017-09-13T04:42:54Z

ready to go?

gucong3000 · 2017-09-13T05:46:44Z

ready to go?

Not yet.
Another new bug in stylelint v8.1.0 (stylelint/stylelint#2853)
package.json use git url to install stylelint, we'd better wait for stylelint release next new virsion.

KarboniteKream · 2017-09-16T18:51:56Z

docs/linter.md

@@ -14,3 +15,16 @@ If you are not happy with the default linting rules, you have several options:
 2. Pick a different ESLint preset when generating the project, for example [eslint-config-airbnb](https://github.com/airbnb/javascript/tree/master/packages/eslint-config-airbnb).

 3. Pick "none" for ESLint preset when generating the project and define your own rules. See [ESLint documentation](http://eslint.org/docs/rules/) for more details.
+
+## stylelint
+This boilerplate uses [stylelint](http://stylint.io/) as for style linting, and uses the [Standard](https://github.com/stylelint/stylelint-config-standard) preset.


You have a typo in the stylelint URL.

Thank you.
fixed.

exarus · 2017-10-07T12:52:55Z

Stylelint v8.2.0 is out.

gucong3000 · 2017-12-03T03:25:06Z

but I'm worried that the circleCI tests fail, it seems the vm runs out of memory.

@LinusBorg
I need some help, I can't find the reason for this problem, the master branch has the same problem.
Could you please try to push this branch to your code base?

LinusBorg · 2017-12-03T10:11:28Z

Okay, I'll push this as a separate branch to our repo and we'll see from there.

gucong3000 · 2017-12-04T04:00:20Z

@LinusBorg #1138

LinusBorg · 2017-12-06T08:44:48Z

circle.yml

@@ -11,3 +11,9 @@ dependencies:
 test:
  override:
    - bash test.sh
+  post:


Hey @gucong3000 Can you explain to me what this post hook does? I'm horrbile with bash.

Move files from ./test/**/* to here:

Then we can download them.

LinusBorg · 2017-12-07T09:26:15Z

@gucong3000 I want to hold off with this PR until #1133 is merged, is that ok?

gucong3000 · 2017-12-07T09:48:17Z

@LinusBorg Yes, of course.

maxmilton · 2017-12-16T11:12:21Z

@gucong3000 love the progress you've made on this so far, however, right now it's broken. I cloned the stylelint feature branch of your repo and initialised a new project but it's not working as expected.

Running yarn run lint:stylelint works correctly and linting errors are displayed.

Running yarn run dev compiles but does not show any errors.

I spent quite a bit of time on this in my own project and I havn't been able to debug the cause. It's definitely caused by some dependency but I couldn't figure out which. Have you experience this in your projects?

gucong3000 · 2017-12-18T05:09:09Z

@maxmilton Thank you for the report.

Running yarn run dev compiles but does not show any errors.

It's been repaired here.

maxmilton · 2017-12-20T09:37:19Z

Just tested and everything works great. Thank you :)

Looking forward to seeing this as part of the template!

gucong3000 · 2018-01-19T03:49:04Z

😢

LinusBorg · 2018-01-19T07:14:01Z

I know, I know :(

All I can say is thank you for being that patient with me so far...

These bigger PRs are always a bit problematic for me in terms of finding time to properly testing them.

I'm also totally unfamiliar it stylelint, so will have to learn the basics to feel comfort able maintaining it on this template.

I will merge this and I won't take a moth t month to do so.

gucong3000 · 2018-02-05T08:49:40Z

Related: stylelint/stylelint#3148

blake-newman and others added 10 commits June 28, 2016 16:43

Added base stylelint configuration.

926cb92

rename meta.json

8aded35

Merge branch 'master' into feature/stylint

3bc1e6d

# Conflicts: # docs/structure.md # meta.js # template/.eslintrc.js # template/build/webpack.dev.conf.js # template/package.json # template/src/App.vue # template/src/components/Hello.vue # template/src/main.js

fix meta.js

e4ebec9

fix eslint

292c84d

fix stylelint cli usage

4bda3d6

lint-on-save for stylelint

79bf95e

fix stylelint errors

51081c7

Merge branch 'master' into feature/stylint

0a541d4

# Conflicts: # template/.eslintrc.js

install stylelint from stylelint

148be44

aladdin-add reviewed Aug 30, 2017

View reviewed changes

刘祺 and others added 3 commits August 31, 2017 09:56

an => a

71ea681

ESLint => stylelint

c663db3

Update package.json

347a1a4

gucong3000 changed the title ~~[WIP] Added stylelint configuration.~~ Added stylelint configuration. Sep 5, 2017

刘祺 added 3 commits September 5, 2017 09:35

artifacts for circleci

bfea365

Merge remote-tracking branch 'origin/master' into feature/stylint

1983127

use bash script to do artifacts job

8f44031

test stylelint HEAD

47c9129

gucong3000 changed the title ~~Added stylelint configuration.~~ [WIP] Added stylelint configuration. Sep 12, 2017

刘祺 added 3 commits September 12, 2017 16:16

fix package.json

1611f2a

Merge remote-tracking branch 'vuejs-templates/master' into feature/st…

fbbadf0

…ylint

Add more stylelint preset

b414930

KarboniteKream reviewed Sep 16, 2017

View reviewed changes

typo in URL.

3b1064e

LinusBorg added intend to implement PR:Review in Progress labels Dec 2, 2017

gucong3000 added 2 commits December 4, 2017 11:06

Merge branch 'develop' into feature/stylint

43de546

Merge branch 'develop' into feature/stylint

47bab50

gucong3000 force-pushed the feature/stylint branch from 5e6bf57 to 47bab50 Compare December 4, 2017 03:25

update dependencies

d10dfec

Merge branch 'develop' into feature/stylint

8593d5b

LinusBorg reviewed Dec 6, 2017

View reviewed changes

Merge branch 'develop' into feature/stylint

a3df122

gucong3000 force-pushed the feature/stylint branch from 8596eeb to a3df122 Compare December 18, 2017 03:59

gucong3000 added 2 commits December 18, 2017 12:16

Fix runLintFix

476a8e2

fix config of StyleLintPlugin

e5d2c78

gucong3000 force-pushed the feature/stylint branch 2 times, most recently from ecde369 to 020b0ea Compare January 19, 2018 07:12

gucong3000 force-pushed the feature/stylint branch 3 times, most recently from d4f082d to 709d922 Compare January 19, 2018 07:28

Merge branch 'develop' into feature/stylint

4532c2b

gucong3000 force-pushed the feature/stylint branch from 709d922 to 4532c2b Compare January 19, 2018 07:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added stylelint configuration. #842

Added stylelint configuration. #842

gucong3000 commented Aug 7, 2017 •

edited

Loading

aladdin-add Aug 30, 2017

aladdin-add left a comment

aladdin-add Aug 30, 2017

gucong3000 Aug 31, 2017

gucong3000 Sep 1, 2017

aladdin-add Aug 30, 2017

gucong3000 commented Sep 5, 2017 •

edited

Loading

aladdin-add commented Sep 13, 2017

gucong3000 commented Sep 13, 2017

KarboniteKream Sep 16, 2017 •

edited

Loading

gucong3000 Sep 18, 2017

exarus commented Oct 7, 2017

gucong3000 commented Dec 3, 2017 •

edited

Loading

LinusBorg commented Dec 3, 2017 •

edited

Loading

gucong3000 commented Dec 4, 2017

LinusBorg Dec 6, 2017

gucong3000 Dec 6, 2017 •

edited

Loading

LinusBorg commented Dec 7, 2017

gucong3000 commented Dec 7, 2017 •

edited

Loading

maxmilton commented Dec 16, 2017

gucong3000 commented Dec 18, 2017 •

edited

Loading

maxmilton commented Dec 20, 2017 •

edited

Loading

gucong3000 commented Jan 19, 2018

LinusBorg commented Jan 19, 2018

gucong3000 commented Feb 5, 2018

Added stylelint configuration. #842

Are you sure you want to change the base?

Added stylelint configuration. #842

Conversation

gucong3000 commented Aug 7, 2017 • edited Loading

aladdin-add Aug 30, 2017

Choose a reason for hiding this comment

aladdin-add left a comment

Choose a reason for hiding this comment

aladdin-add Aug 30, 2017

Choose a reason for hiding this comment

gucong3000 Aug 31, 2017

Choose a reason for hiding this comment

gucong3000 Sep 1, 2017

Choose a reason for hiding this comment

aladdin-add Aug 30, 2017

Choose a reason for hiding this comment

gucong3000 commented Sep 5, 2017 • edited Loading

aladdin-add commented Sep 13, 2017

gucong3000 commented Sep 13, 2017

KarboniteKream Sep 16, 2017 • edited Loading

Choose a reason for hiding this comment

gucong3000 Sep 18, 2017

Choose a reason for hiding this comment

exarus commented Oct 7, 2017

gucong3000 commented Dec 3, 2017 • edited Loading

LinusBorg commented Dec 3, 2017 • edited Loading

gucong3000 commented Dec 4, 2017

LinusBorg Dec 6, 2017

Choose a reason for hiding this comment

gucong3000 Dec 6, 2017 • edited Loading

Choose a reason for hiding this comment

LinusBorg commented Dec 7, 2017

gucong3000 commented Dec 7, 2017 • edited Loading

maxmilton commented Dec 16, 2017

gucong3000 commented Dec 18, 2017 • edited Loading

maxmilton commented Dec 20, 2017 • edited Loading

gucong3000 commented Jan 19, 2018

LinusBorg commented Jan 19, 2018

gucong3000 commented Feb 5, 2018

gucong3000 commented Aug 7, 2017 •

edited

Loading

gucong3000 commented Sep 5, 2017 •

edited

Loading

KarboniteKream Sep 16, 2017 •

edited

Loading

gucong3000 commented Dec 3, 2017 •

edited

Loading

LinusBorg commented Dec 3, 2017 •

edited

Loading

gucong3000 Dec 6, 2017 •

edited

Loading

gucong3000 commented Dec 7, 2017 •

edited

Loading

gucong3000 commented Dec 18, 2017 •

edited

Loading

maxmilton commented Dec 20, 2017 •

edited

Loading