Remove unused fs require from webpack.base.conf.js #893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems that this is a leftover from a recent change that I had to undo because it caused issue. Thanks! |
LinusBorg
added a commit
that referenced
this pull request
Sep 5, 2017
LinusBorg
pushed a commit
that referenced
this pull request
Sep 30, 2017
frandiox
pushed a commit
to OnsenUI/vue-cordova-webpack
that referenced
this pull request
Oct 13, 2017
* Update vue-loader link (vuejs-templates#886) * Merge some small fixes (vuejs-templates#900) * Remove unused fs require from webpack.base.conf.js (vuejs-templates#893) * cleanup some leftover from reverting vuejs-templates#688 * update URL of ESLint to https * fix missing comma from conflict resolution
LinusBorg
pushed a commit
that referenced
this pull request
Nov 8, 2017
frandiox
pushed a commit
to OnsenUI/vue-cordova-webpack
that referenced
this pull request
Dec 25, 2017
* Update vue-loader link (vuejs-templates#886) * Merge some small fixes (vuejs-templates#900) * Remove unused fs require from webpack.base.conf.js (vuejs-templates#893) * cleanup some leftover from reverting vuejs-templates#688 * fix postcss config * userPostCSS config
shenron
pushed a commit
to shenron/webpack
that referenced
this pull request
Mar 20, 2018
* Update vue-loader link (vuejs-templates#886) * Merge some small fixes (vuejs-templates#900) * Remove unused fs require from webpack.base.conf.js (vuejs-templates#893) * cleanup some leftover from reverting vuejs-templates#688 * fix postcss config * userPostCSS config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I applied the linter script to config files (a good idea, IMO), and found this
fswas unused.Can someone with more familiarity with the project check that the cli doesn't insert anything into this file that uses
fs? I'm pretty sure it doesn't.