build es module #1039
Closed
build es module #1039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there anyway to get this working with the v4.0.0-alpha.10 release now? |
|
@longfellowone I wasn't aware that it's not working, I'll try to find some time to take a look. |
|
Thanks for your PR! There are now an ESM and Single-File AMD builds on v4 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Added an ES module build along with the existing
commonjsbuild to@vue/apollo-composableWhy?
I expect many Vue 3 projects will rely on
viteinstead of webpack as a bundler. Vite famously works with ES modules and is required to get proper named imports (see for example #1029). commonjs imports kind of work with default imports but a proper ES module build will be required in the long run.