fix: fix sourceMap path separator on Windows, default sourceRoot to "" #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enforces separator '/' is used for any OS. It also changed sourceRoot default value from process.cwd() to empty string, because local directory is irrelevant in browser where sourceMap is consumed. closes #47
|
I will wait for this fix to be released before doing a follow up PR for |
znck
approved these changes
Jan 14, 2019
znck
pushed a commit
to vuejs/vue-component-compiler
that referenced
this pull request
Feb 1, 2019
* chore: upgrade packages, cleanup type errors Took the opportunity to update TS to latest version, cleanup all type errors. * fix: normalize source map file path on windows Updated test snapshot file. 1. Sources paths was cleaned up by upgrading component-compiler-utils. 2. Styles mapping changes are due to newer version of postcss (from component-compiler-utils). 3. postcss rawResult is removed. * The rawResult contains ast tree which postcss always prepends current working directory to referencing file name. * This is a main pain point of maintaining this snapshot test. * The correctness of rawResult is responsibility of postcss, not vue compiler. So it's irrelevant to test it here. This is a companion PR for vuejs/component-compiler-utils#51
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enforces separator '/' is used for any OS. It also changed sourceRoot default value from process.cwd() to empty string, because local directory is irrelevant in browser where sourceMap is consumed.
closes #47