Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support Vue3 style app-level provide #945

Merged
merged 2 commits into from
Jun 24, 2022
Merged

feat: support Vue3 style app-level provide #945

merged 2 commits into from
Jun 24, 2022

Conversation

lsdsjy
Copy link
Contributor

@lsdsjy lsdsjy commented Jun 23, 2022

Kingwl
Kingwl approved these changes Jun 23, 2022
View reviewed changes
Copy link
Member

@Kingwl Kingwl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It’s very helpful to me!

@xiaoxiangmoe
Copy link
Collaborator

it is helpful to me too

@antfu antfu merged commit d167b9b into vuejs:main Jun 24, 2022
@Weetbix
Copy link

Weetbix commented Jul 4, 2022

Am I right in thinking this is not compatible with Vue 2.7 because it does not include createApp?

@lsdsjy
Copy link
Contributor Author

lsdsjy commented Jul 8, 2022

You can use vue-demi as it polyfills createApp for Vue 2.7. See vueuse/vue-demi@5637e7b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kingwl Kingwl Kingwl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lsdsjy @xiaoxiangmoe @Weetbix @Kingwl @antfu