refactor: should throw errors in computed getters

vuejs · Apr 24, 2024 · 85f3592 · 85f3592
1 parent 9fd1284
commit 85f3592
Showing 1 changed file with 6 additions and 5 deletions.
diff --git a/packages/reactivity/src/effect.ts b/packages/reactivity/src/effect.ts
@@ -375,12 +375,13 @@ export function refreshComputed(computed: ComputedRefImpl) {
     }
   } catch (err) {
     dep.version++
+    throw err
+  } finally {
+    activeSub = prevSub
+    shouldTrack = prevShouldTrack
+    cleanupDeps(computed)
+    computed.flags &= ~EffectFlags.RUNNING
   }
-
-  activeSub = prevSub
-  shouldTrack = prevShouldTrack
-  cleanupDeps(computed)
-  computed.flags &= ~EffectFlags.RUNNING
 }
 
 function removeSub(link: Link) {