Skip to content

Commit

Permalink
chore: improve renderComponentRoot warn message (#10914)
Browse files Browse the repository at this point in the history
  • Loading branch information
btea authored Oct 14, 2024
1 parent 4e19a99 commit a038505
Show file tree
Hide file tree
Showing 2 changed files with 22 additions and 1 deletion.
21 changes: 21 additions & 0 deletions packages/runtime-core/__tests__/rendererAttrsFallthrough.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
import {
Fragment,
type FunctionalComponent,
Teleport,
createBlock,
createCommentVNode,
createElementBlock,
Expand Down Expand Up @@ -391,6 +392,26 @@ describe('attribute fallthrough', () => {
expect(`Extraneous non-emits event listeners`).toHaveBeenWarned()
})

it('should warn when fallthrough fails on teleport root node', () => {
const Parent = {
render() {
return h(Child, { class: 'parent' })
},
}
const root = document.createElement('div')

const Child = defineComponent({
render() {
return h(Teleport, { to: root }, h('div'))
},
})

document.body.appendChild(root)
render(h(Parent), root)

expect(`Extraneous non-props attributes (class)`).toHaveBeenWarned()
})

it('should dedupe same listeners when $attrs is used during render', () => {
const click = vi.fn()
const count = ref(0)
Expand Down
2 changes: 1 addition & 1 deletion packages/runtime-core/src/componentRenderUtils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ export function renderComponentRoot(
`Extraneous non-props attributes (` +
`${extraAttrs.join(', ')}) ` +
`were passed to component but could not be automatically inherited ` +
`because component renders fragment or text root nodes.`,
`because component renders fragment or text or teleport root nodes.`,
)
}
if (eventAttrs.length) {
Expand Down

0 comments on commit a038505

Please sign in to comment.