Skip to content

Commit

Permalink
fix(runtime-core): avoid rendering plain object as VNode (#12038)
Browse files Browse the repository at this point in the history
  • Loading branch information
edison1105 authored Sep 26, 2024
1 parent faf55a1 commit cb34b28
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 1 deletion.
9 changes: 9 additions & 0 deletions packages/runtime-core/__tests__/rendererChildren.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,15 @@ test('array children -> text children', () => {
expect(inner(root)).toBe('<div>hello</div>')
})

test('plain object child', () => {
const root = nodeOps.createElement('div')
const foo = { foo: '1' }
// @ts-expect-error
render(h('div', null, [foo]), root)
expect('Invalid VNode type').not.toHaveBeenWarned()
expect(inner(root)).toBe('<div>[object Object]</div>')
})

describe('renderer: keyed children', () => {
let root: TestElement
let elm: TestElement
Expand Down
2 changes: 1 addition & 1 deletion packages/runtime-core/src/vnode.ts
Original file line number Diff line number Diff line change
Expand Up @@ -793,7 +793,7 @@ export function normalizeVNode(child: VNodeChild): VNode {
// #3666, avoid reference pollution when reusing vnode
child.slice(),
)
} else if (typeof child === 'object') {
} else if (isVNode(child)) {
// already vnode, this should be the most common since compiled templates
// always produce all-vnode children arrays
return cloneIfMounted(child)
Expand Down

0 comments on commit cb34b28

Please sign in to comment.