Skip to content

Commit

Permalink
fix(build): revert entities to 4.5 to avoid runtime resolution errors
Browse files Browse the repository at this point in the history
close #11603
  • Loading branch information
yyx990803 committed Aug 15, 2024
1 parent 5861229 commit e9e0815
Show file tree
Hide file tree
Showing 6 changed files with 10 additions and 12 deletions.
4 changes: 4 additions & 0 deletions .github/renovate.json5
Original file line number Diff line number Diff line change
Expand Up @@ -58,5 +58,9 @@
// pinned
// only used in example for e2e tests
'marked',

// pinned, 5.0+ has exports issues
// https://github.com/vuejs/core/issues/11603
'entities',
],
}
2 changes: 1 addition & 1 deletion packages/compiler-core/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@
"dependencies": {
"@babel/parser": "catalog:",
"@vue/shared": "workspace:*",
"entities": "^5.0.0",
"entities": "^4.5.0",
"estree-walker": "catalog:",
"source-map-js": "catalog:"
},
Expand Down
2 changes: 1 addition & 1 deletion packages/compiler-core/src/parser.ts
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ import {
isSimpleIdentifier,
isStaticArgOf,
} from './utils'
import { decodeHTML } from 'entities/dist/decode.js'
import { decodeHTML } from 'entities/lib/decode.js'
import {
type ParserOptions as BabelOptions,
parse,
Expand Down
2 changes: 1 addition & 1 deletion packages/compiler-core/src/tokenizer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ import {
EntityDecoder,
fromCodePoint,
htmlDecodeTree,
} from 'entities/dist/decode.js'
} from 'entities/lib/decode.js'

export enum ParseMode {
BASE,
Expand Down
10 changes: 2 additions & 8 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion rollup.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -258,7 +258,7 @@ function createConfig(format, output, plugins = []) {
'source-map-js',
'@babel/parser',
'estree-walker',
'entities/dist/decode.js',
'entities/lib/decode.js',
]

if (isGlobalBuild || isBrowserESMBuild || isCompatPackage) {
Expand Down

0 comments on commit e9e0815

Please sign in to comment.