-
-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
View isn't updated in a weird case (combination of many factors, transition, injection & computed) #2768
Comments
Repetitive description. And its really complicated. |
repetitive desc is removed |
I debugged this bug locally, but found it works. My local code is the latest master. so I think it's fixed by some commits. |
It works before So maybe finding the reason is crucial to make it not regress again. Since nested slots may trigger some subtle bugs. |
Thanks a lot @edison1105 ! |
@posva I think it is worth to add a test case make it not regress again.Although I haven't found the specific reason. |
yeah, PR welcome for a non regression test! |
OK, I will try it later. |
@posva
@07akioni You are right, I tested it. When I remove the const OuterWrapper = defineComponent({
template: "#outer",
name: "OuterWrapper",
components: {
// Test,
InnerWrapper
},
...
}) |
Yep, there are many ways to make it work such as remove transition, remove some computed, etc. |
@07akioni |
The case is extract from a real component.
|
Great thanks for @edison1105 's PR, but that still has shortcomings. I have written enough for the details, check out: #3184 |
Version
3.0.4
Reproduction link
https://codesandbox.io/s/lucid-wind-c4jky?file=/src/components/OuterWrapper.vue
Steps to reproduce
follow the link.
Although the case seems not that 'minimal', I can't figure out a smaller one. Any small change may make the demo work as expected.
What is expected?
After the button is clicked, it should disappeared.
What is actually happening?
It stays there.
The text was updated successfully, but these errors were encountered: