fix(types): allow style to be an array in JSX #2947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vue supports array of string and CssProperties in style attribute.
znck
approved these changes
Jan 6, 2021
shivkumar5
approved these changes
Jan 6, 2021
KaelWD
reviewed
Jan 31, 2021
packages/runtime-dom/types/jsx.d.ts
Outdated
| @@ -249,7 +249,7 @@ export interface HTMLAttributes extends AriaAttributes, EventHandlers<Events> { | |||
| innerHTML?: string | |||
|
|
|||
| class?: any | |||
| style?: string | CSSProperties | |||
| style?: string | CSSProperties | Array<string | CSSProperties> | |||
There was a problem hiding this comment.
This array can be deeply nested.
type HTMLStyle = string | CSSProperties | Array<HTMLStyle>
There was a problem hiding this comment.
Do we support deeply nested styles? Same issue is popping for class attribute.
There was a problem hiding this comment.
There was a problem hiding this comment.
Same issue is popping for class attribute
wdym? class flattens arrays too but is already typed as any so isn't a problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vue supports array of string and CssProperties in style attribute.
