Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(types): allow style to be an array in JSX #2947

Merged
merged 2 commits into from
Mar 1, 2021
Merged

fix(types): allow style to be an array in JSX #2947

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
23c4c6c
update jsx.d.ts
kadiryazici Jan 5, 2021
bc1e6e3
Update jsx.d.ts
yyx990803 Mar 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/runtime-dom/types/jsx.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,7 @@ export interface HTMLAttributes extends AriaAttributes, EventHandlers<Events> {
innerHTML?: string

class?: any
style?: string | CSSProperties
style?: string | CSSProperties | Array<string | CSSProperties>
Copy link
Contributor

@KaelWD KaelWD Jan 31, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This array can be deeply nested.

type HTMLStyle = string | CSSProperties | Array<HTMLStyle>

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@znck WDYT?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we support deeply nested styles? Same issue is popping for class attribute.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes: https://codepen.io/kaelwd/pen/KKNmvqY?editors=1010

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same issue is popping for class attribute

wdym? class flattens arrays too but is already typed as any so isn't a problem.


// Standard HTML Attributes
accesskey?: string
Expand Down