Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

!__DEV__ always equals false #8312

Closed
BCGen opened this issue May 14, 2023 · 0 comments · Fixed by #8314
Closed

!__DEV__ always equals false #8312

BCGen opened this issue May 14, 2023 · 0 comments · Fixed by #8314
Labels
🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage.

Comments

@BCGen
Copy link

BCGen commented May 14, 2023

Vue version

3.3.2

Link to minimal reproduction

5851eaa

Steps to reproduce

Create project with vue 3.3.2, and test invalid prop type check, no warning message in browser console.

What is expected?

In develop environment, process.env.NODE_ENV !== "production" should be true.

What is actually happening?

5851eaa

I found that this commit causes !__DEV__ to be transformed to !process.env.NODE_ENV !== "production", resulting in it always being false.

CleanShot 2023-05-15 at 03 39 37

CleanShot 2023-05-15 at 03 57 09

System Info

System:
    OS: macOS 13.3.1
    CPU: (12) arm64 Apple M2 Pro
    Memory: 554.94 MB / 32.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 18.16.0 - ~/.volta/tools/image/node/18.16.0/bin/node
    npm: 9.5.1 - ~/.volta/tools/image/node/18.16.0/bin/npm
  Browsers:
    Edge: 113.0.1774.42
    Safari: 16.4
  npmPackages:
    vue: ^3.3.2 => 3.3.2

Any additional comments?

No response

@edison1105 edison1105 added the 🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. label May 15, 2023
KaelWD referenced this issue in vuetifyjs/vuetify May 29, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Sep 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage.
Projects
None yet
2 participants