Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler-sfc): :is() and :where() in compound selectors #10522

Merged
merged 9 commits into from
Mar 25, 2024
37 changes: 37 additions & 0 deletions packages/compiler-sfc/__tests__/compileStyle.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,43 @@ describe('SFC scoped CSS', () => {
`)
})

// #10511
test(':is and :where with same pre-selector should have right priority', () => {
Doctor-wu marked this conversation as resolved.
Show resolved Hide resolved
expect(
compileScoped(`.div { color: red }; .div:where(:hover) { color: blue }`),
Doctor-wu marked this conversation as resolved.
Show resolved Hide resolved
).toMatchInlineSnapshot(`
".div[data-v-test] { color: red
};
.div[data-v-test]:where(:hover) { color: blue
}"`)

expect(
compileScoped(`.div { color: red }; .div:is(:hover) { color: blue }`),
).toMatchInlineSnapshot(`
".div[data-v-test] { color: red
};
.div[data-v-test]:is(:hover) { color: blue
}"`)

expect(
compileScoped(
`.div { color: red }; .div:where(.foo:hover) { color: blue }`,
),
).toMatchInlineSnapshot(`
".div[data-v-test] { color: red
};
.div[data-v-test]:where(.foo:hover) { color: blue
}"`)

expect(
compileScoped(`.div { color: red }; .div:is(.foo:hover) { color: blue }`),
).toMatchInlineSnapshot(`
".div[data-v-test] { color: red
};
.div[data-v-test]:is(.foo:hover) { color: blue
}"`)
})

test('media query', () => {
expect(compileScoped(`@media print { .foo { color: red }}`))
.toMatchInlineSnapshot(`
Expand Down
4 changes: 3 additions & 1 deletion packages/compiler-sfc/src/style/pluginScoped.ts
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,9 @@ function rewriteSelector(

if (
(n.type !== 'pseudo' && n.type !== 'combinator') ||
(n.type === 'pseudo' && (n.value === ':is' || n.value === ':where'))
(n.type === 'pseudo' &&
(n.value === ':is' || n.value === ':where') &&
!node)
) {
node = n
}
Expand Down