Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(runtime-dom): When the prop of a custom element is undefined, the property should be deleted #11278

Closed
wants to merge 2 commits into from

Conversation

linzhe141
Copy link
Contributor

close #11276

Copy link

github-actions bot commented Jul 2, 2024

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 89.4 kB (+34 B) 34.2 kB (+11 B) 30.8 kB (+26 B)
vue.global.prod.js 146 kB (+34 B) 53.6 kB (+9 B) 47.7 kB (+46 B)

Usages

Name Size Gzip Brotli
createApp 51.3 kB 20.1 kB 18.3 kB
createSSRApp 54.7 kB 21.4 kB 19.5 kB
defineCustomElement 53.6 kB (+34 B) 20.9 kB (+10 B) 19 kB (-9 B)
overall 65 kB 25.1 kB 22.7 kB

Copy link

@Maxim-Mazurok Maxim-Mazurok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be a good idea to add some tests to avoid regression in the future

Copy link

@Maxim-Mazurok Maxim-Mazurok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are looking awesome 👍

I wonder: will this new logic affect any use-cases where someone would try to pass undefined as a prop value? Or if they omit the prop. Will it make it false where undefined was expected previously? Basically don't want to be too selfish with only solving my use-case with Boolean prop, maybe should think about other cases as well. On other hand I'd expect some tests to fail if that was the problem, so maybe we're good...

@so1ve
Copy link
Member

so1ve commented Jul 9, 2024

/ecosystem-ci run

@vue-bot
Copy link
Contributor

vue-bot commented Jul 9, 2024

📝 Ran ecosystem CI: Open

suite result latest scheduled
language-tools failure failure
nuxt success failure
pinia success success
primevue success success
quasar success success
radix-vue success success
router success failure
test-utils success success
vant success success
vite-plugin-vue success success
vitepress success success
vue-i18n success success
vue-macros success success
vuetify success success
vueuse success success
vue-simple-compiler success success

@edison1105
Copy link
Member

Closing as #11276 has been fixed via 506c4c5

@edison1105 edison1105 closed this Oct 8, 2024
@linzhe141 linzhe141 deleted the fix-custom-element-set-prop branch October 8, 2024 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom Web Elements/Components receive undefined instead of false on subsequent re-render
5 participants