-
-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(sfc): directly use import bindings without adding prefix #11319
Open
edison1105
wants to merge
13
commits into
vuejs:main
Choose a base branch
from
edison1105:fix/11273
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size ReportBundles
Usages
|
edison1105
changed the title
fix(compile-sfc): check import usage in cssVars
fix(ssr): properly rewrite ssr cssVars
Jul 10, 2024
/ecosystem-ci run |
📝 Ran ecosystem CI: Open
|
📝 Ran ecosystem CI: Open
|
/ecosystem-ci run |
📝 Ran ecosystem CI: Open
|
edison1105
changed the title
fix(ssr): properly rewrite ssr cssVars
fix(ssr): properly rewrite user import bindings
Jul 10, 2024
/ecosystem-ci run |
edison1105
changed the title
fix(ssr): properly rewrite user import bindings
refactor(sfc): codegen for user import bindings
Jul 17, 2024
📝 Ran ecosystem CI: Open
|
❌ Deploy Preview for vue-sfc-playground failed.
|
commit: @vue/compiler-core
@vue/compiler-dom
@vue/compiler-sfc
@vue/compiler-ssr
@vue/reactivity
@vue/runtime-core
@vue/runtime-dom
@vue/server-renderer
@vue/shared
vue
@vue/compat
|
/ecosystem-ci run |
📝 Ran ecosystem CI: Open
|
edison1105
changed the title
refactor(sfc): codegen for user import bindings
refactor(sfc): directly use import bindings without adding prefix
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #11273
The underlying issue is that user import bindings are rewritten to $setup.Color in non-inline mode and
Color
is not returned in the setup function.__return__
, which requires modifyingisImportUsed
to check if the import var is used incssVars
.