Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(runtime-core): correct type inference of all-optional props #11644

Merged
merged 5 commits into from
Sep 20, 2024

Conversation

KazariEX
Copy link
Contributor

@KazariEX KazariEX commented Aug 17, 2024

Copy link

github-actions bot commented Aug 17, 2024

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 100 kB 37.7 kB 34 kB
vue.global.prod.js 159 kB 57.6 kB 51.3 kB

Usages

Name Size Gzip Brotli
createApp (CAPI only) 48.8 kB 18.8 kB 17.2 kB
createApp 55.3 kB 21.2 kB 19.4 kB
createSSRApp 59.3 kB 22.9 kB 20.9 kB
defineCustomElement 60 kB 22.8 kB 20.7 kB
overall 69 kB 26.3 kB 23.9 kB

Copy link

pkg-pr-new bot commented Aug 17, 2024

Open in Stackblitz

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@11644

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@11644

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@11644

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@11644

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@11644

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@11644

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@11644

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@11644

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@11644

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@11644

vue

pnpm add https://pkg.pr.new/vue@11644

commit: d04a009

@KazariEX
Copy link
Contributor Author

I don't know how to add test cases because this issue seems to only occur in specific situations.

Copy link

netlify bot commented Aug 18, 2024

Deploy Preview for vue-sfc-playground failed.

Name Link
🔨 Latest commit 3ac8835
🔍 Latest deploy log https://app.netlify.com/sites/vue-sfc-playground/deploys/66c16a0d9c468f0008353c70

Copy link

netlify bot commented Aug 18, 2024

Deploy Preview for vue-next-template-explorer failed.

Name Link
🔨 Latest commit 3ac8835
🔍 Latest deploy log https://app.netlify.com/sites/vue-next-template-explorer/deploys/66c16a0dab76b7000952f6e8

@yyx990803
Copy link
Member

/ecosystem-ci run

@vue-bot
Copy link
Contributor

vue-bot commented Aug 19, 2024

📝 Ran ecosystem CI: Open

suite result latest scheduled
language-tools failure failure
nuxt success success
pinia success success
primevue success success
quasar success success
radix-vue success success
router success success
test-utils success success
vant success success
vite-plugin-vue success success
vitepress success success
vue-i18n success success
vue-macros success success
vuetify success success
vueuse success success
vue-simple-compiler success success

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review This PR requires more reviews scope: types
Projects
None yet
5 participants